Speedup SumLocksByDenom #7172
Merged
Speedup SumLocksByDenom #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
mattverse,
czarcas7ic and
AlpinYukseloglu
as code owners
ValarDragon
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Use mut int ops in a hotloop * Also eliminate runtime-eq check * Add changelog (cherry picked from commit 729d43f)
ValarDragon
added a commit
that referenced
this pull request
Dec 21, 2023
* Use mut int ops in a hotloop * Also eliminate runtime-eq check * Add changelog (cherry picked from commit 729d43f) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Dec 21, 2023
* Use mut int ops in a hotloop * Also eliminate runtime-eq check * Add changelog (cherry picked from commit 729d43f) Co-authored-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State compatible speedups to SumLocksByDenom code.
I expect this to reduce epoch CPU time by 4 seconds. (maybe a bit more with garbage collector reductions)
This entire for loop should later get eliminated with #7119, but that can come later / after being more certain around state compat.